Skip to content

Add Extensive Logging #25005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Open

Add Extensive Logging #25005

wants to merge 15 commits into from

Conversation

@kean
Copy link
Contributor

@kean kean commented Nov 21, 2025 •
edited
Loading

Description

  • Integrate Pulse and set it up using SwiftLog Logging System
  • Add a "bolt" button to "Experimental Features". Tap it five times, and it'll show a new "Super Experimental Features" section.
  • Show "Extensive Logging" flag in the new section. When you enable it, it'll show a warning alert.
  • Add "Logger" section in "App Settings" (if enabled)

Screenshot 2025-11-21 at 4 05 01 PM Screenshot 2025-11-21 at 4 04 05 PM
Screenshot 2025-11-21 at 4 05 13 PM Screenshot 2025-11-21 at 4 07 36 PM

@kean kean added the General label Nov 21, 2025
@kean kean added this to the 26.5 milestone Nov 21, 2025
@kean kean requested a review from jkmassel November 21, 2025 21:09
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 21, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30032
VersionPR #25005
Bundle IDorg.wordpress.alpha
Commitb2ed5de
Installation URL641fet35j1r70
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 21, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30032
VersionPR #25005
Bundle IDcom.jetpack.alpha
Commitb2ed5de
Installation URL0t53p0usoj5jg
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot wpmobilebot modified the milestones: 26.5, 26.6 Nov 23, 2025
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 23, 2025

Version 26.5 has now entered code-freeze, so the milestone of this PR has been updated to 26.6.

@kean kean force-pushed the task/add-pulse-logger branch from 540bef8 to 942aeec Compare November 24, 2025 13:16
@kean
Copy link
Contributor Author

kean commented Nov 24, 2025

Renamed it to "Developer Tools"

kean
kean commented Nov 24, 2025
View reviewed changes
dcalhoun
dcalhoun reviewed Nov 24, 2025
View reviewed changes
crazytonyli
crazytonyli reviewed Nov 25, 2025
View reviewed changes
Modules/Sources/WordPressUI/Views/Settings/ExperimentalFeatures/ExperimentalFeaturesList.swift
.font(.system(size: 20))
.foregroundColor(.secondary)
.symbolEffect(.bounce.up, value: tapCount)
.onTapGesture {
Copy link
Contributor

@crazytonyli crazytonyli Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does onTapGesture(count: 5) { isDeveloperModeEnabled = true } work?

Copy link
Contributor Author

@kean kean Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to change it and try it.
I generated all the original code.

@crazytonyli
Copy link
Contributor

crazytonyli commented Nov 25, 2025

If I understand correctly, with the changes in this PR, the app now always uses Pulse to log HTTP requests and responses, and the feature toggle controls whether the user can see those logs. Considering 99% of the users won't turn on the feature toggle and view the logs, to avoid running code and taking up the app's memory for nothing, should we change the model to only log HTTP requests when the feature toggle is on?

@kean
Copy link
Contributor Author

kean commented Nov 25, 2025 •
edited
Loading

should we change the model to only log HTTP requests when the feature toggle is on?

There is a significant impact on performance and app on-disk see. If has to be a debug-only feature.

@dcalhoun dcalhoun mentioned this pull request Dec 1, 2025
Merged
@dcalhoun
task: Reset GutenbergKit environment variable to default: NO
b2ed5de 
We should only enable this for development environments.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcalhoun dcalhoun dcalhoun left review comments

@crazytonyli crazytonyli crazytonyli left review comments

@jkmassel jkmassel Awaiting requested review from jkmassel

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

General

Projects

None yet

Milestone

26.6

Development

Successfully merging this pull request may close these issues.

6 participants

@kean @wpmobilebot @crazytonyli @dcalhoun @jkmassel